551278 - Tracking bug for build and release of Firefox 3.7a3

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Waiting for go.

Note:
1) from dev meeting today, we'll provide updates from a1->a3 and a2->a3. Given the timeline, its ok if we do this manually.

2) Even if bug#540833 does block us doing updates for Mac with a3, we will provide updates for win32, linux.

Comment 1

[tymerkaev]

Attachment: [mozilla-central] bump to 3.7a4pre/1.9.3a4pre

Comment 2

[tymerkaev]

Attachment: [buildbot-configs] Automation config for build1

Comment 3

[tymerkaev]

Comment on attachment 431611 [details] [diff] [review]
 [buildbot-configs] Automation config for build1

>diff --git a/mozilla2/release-firefox-mozilla-central.py b/mozilla2/release-firefox-mozilla-central.py
>--- a/mozilla2/release-firefox-mozilla-central.py
>+++ b/mozilla2/release-firefox-mozilla-central.py
>@@ -2,7 +2,7 @@
> hgSshKey           = '~cltbld/.ssh/ffxbld_dsa'
> sourceRepoName     = 'mozilla-central'
> sourceRepoPath     = sourceRepoName
>-sourceRepoRevision = '3874a469cf09'
>+sourceRepoRevision = '10d903dc22ae'
> relbranchOverride  = ''
> l10nRepoPath       = 'l10n-central'
> l10nRevisionFile   = 'l10n-changesets'
>@@ -14,5 +14,5 @@
> # appVersion and oldAppVersion are optional definitions used in places that
> # don't care about what we call it. Eg, when version bumping we will bump to
> # appVersion, not version.
>-version            = '3.7a2'
>+version            = '3.7a3'
> appVersion         = version
>@@ -18,3 +18,3 @@
> appVersion         = version
>-milestone          = '1.9.3a2'
>+milestone          = '1.9.3a3'
> buildNumber        = 1
>@@ -20,8 +20,8 @@
> buildNumber        = 1
>-baseTag            = 'FIREFOX_3_7a2'
>+baseTag            = 'FIREFOX_3_7a3'
> oldVersion         = ''
> oldAppVersion      = ''
> oldBuildNumber     = 1
> oldBaseTag         = ''
> enUSPlatforms      = ('linux', 'win32', 'macosx')
> l10nPlatforms      = ()
>@@ -22,10 +22,10 @@
> oldVersion         = ''
> oldAppVersion      = ''
> oldBuildNumber     = 1
> oldBaseTag         = ''
> enUSPlatforms      = ('linux', 'win32', 'macosx')
> l10nPlatforms      = ()
>-# TODO: create this file before 3.7a2
>+# TODO: create these files before first 3.7 requiring updates
> patcherConfig      = 'moz193-branch-patcher2.cfg'
> patcherToolsTag    = 'UPDATE_PACKAGING_R9'
> ftpServer          = 'ftp.mozilla.org'

Comment 4

[[e-mail] (:bhearsum)]

per the delivery meeting today, we'll be doing updates from a1 and a2, and will *only* be serving completes until bug 546710 is fixed

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 431611 [details] [diff] [review]
 [buildbot-configs] Automation config for build1

>diff --git a/mozilla2/release-firefox-mozilla-central.py b/mozilla2/release-firefox-mozilla-central.py
>--- a/mozilla2/release-firefox-mozilla-central.py
>+++ b/mozilla2/release-firefox-mozilla-central.py
>@@ -2,7 +2,7 @@
> hgSshKey           = '~cltbld/.ssh/ffxbld_dsa'
> sourceRepoName     = 'mozilla-central'
> sourceRepoPath     = sourceRepoName
>-sourceRepoRevision = '3874a469cf09'
>+sourceRepoRevision = '50fe27903561'

This isn't right. When we create config patches in advance we use 'TO BE FILLED OUT' or something else invalid to ensure we don't accidentally build from the wrong changeset. The right revision is signed off on by the release drivers.

> relbranchOverride  = ''
> l10nRepoPath       = 'l10n-central'
> l10nRevisionFile   = 'l10n-changesets'
>@@ -14,5 +14,5 @@
> # appVersion and oldAppVersion are optional definitions used in places that
> # don't care about what we call it. Eg, when version bumping we will bump to
> # appVersion, not version.
>-version            = '3.7a2'
>+version            = '3.7a3'
> appVersion         = version
>@@ -18,3 +18,3 @@
> appVersion         = version
>-milestone          = '1.9.3a2'
>+milestone          = '1.9.3a3'
> buildNumber        = 1
>@@ -20,8 +20,8 @@
> buildNumber        = 1
>-baseTag            = 'FIREFOX_3_7a2'
>+baseTag            = 'FIREFOX_3_7a3'
> oldVersion         = ''
> oldAppVersion      = ''
> oldBuildNumber     = 1
> oldBaseTag         = ''

We're going to want to set these this time, since we're doing updates.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: automation config, with changeset + updates

Comment 7

[Armen [:armenzg]]

Comment on attachment 432534 [details] [diff] [review]
automation config, with changeset + updates

Looks good.

Comment 8

[[e-mail] (:bhearsum)]

Comment on attachment 432534 [details] [diff] [review]
automation config, with changeset + updates

changeset:   2153:23612abc5ac5

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 431610 [details] [diff] [review]
[mozilla-central] bump to 3.7a4pre/1.9.3a4pre

changeset:   39455:a31830050234

Comment 10

[[e-mail] (:bhearsum)]

Attachment: initial 1.9.3 patcher config

I haven't tested this, but this _should_ get us partials from 3.7a2 and completes from 3.7a1. Note that mozilladeveloperpreview is used in the filename, and devpreview is used as the bouncer product. The rest is pretty standard.

Comment 11

[[e-mail] (:bhearsum)]

Attachment: update verify configs for 3.7a3

Again, untested, but should work fine.

I'm going to have to comment out the parts of ReleaseUpdatesFactory that bump the verify configs, or else we'll get overwritten with bad ones.

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 432657 [details] [diff] [review]
initial 1.9.3 patcher config

>            <3.7a3>
...
>                prettyVersion   3.7 Alpha 3

Looks fine, but what does this look like in the update dialog? Ideally we'd want something like "Mozilla Developer Preview 3".

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 432664 [details] [diff] [review]
update verify configs for 3.7a3

>diff --git a/release/updates/moz193-firefox-linux.cfg b/release/updates/moz193-firefox-linux.cfg
>+release="3.7a2" product="Firefox" platform="Linux_x86-gcc3" build_id="20100228153229" locales="en-US" channel="betatest" from="/firefox/releases/3.7a2/linux-i686/%locale%/mozilladeveloperpreview-3.7a2.tar.bz2" 

Wrong path for from, should be /firefox/releases/devpreview/1.9.3a2/linux....
Similar for mac and win32.

>diff --git a/release/updates/moz193-firefox-mac.cfg b/release/updates/moz193-
>+# 3.7a1 macosx
>+release="3.7a1" product="Firefox" platform="Darwin_Universal-gcc3" build_id="20100208064801" locales="en-US" channel="betatest" 

Wrong buildID, should be 20100208064157.

>diff --git a/release/updates/moz193-firefox-win32.cfg b/release/updates/moz193-firefox-win32.cfg

>+# 3.7a1 win32
>+release="3.7a1" product="Firefox" platform="WINNT_x86-msvc" build_id="20100208064157" locales="en-US" channel="betatest" 

Should be 20100208105635 (you've got the mac a1 there). I was looking at the txt files in the candidate dirs.

Comment 14

[[e-mail] (:bhearsum)]

Attachment: verify configs with nick's comments addressed

Comment 15

[[e-mail] (:bhearsum)]

Attachment: patcher config w/ different pretty version

Going to carry review forward on this one. It's the same as before, with "Developer Preview N" for the prettyVersion's rather than "3.7 Alpha N", which will end up with the update dialogs saying "Firefox Developer Preview N", which isn't exactly what we're shipping as but it's the best we can do.

Comment 16

[[e-mail] (:bhearsum)]

Comment on attachment 432785 [details] [diff] [review]
patcher config w/ different pretty version

Checking in moz193-branch-patcher2.cfg;
/cvsroot/mozilla/tools/patcher-configs/moz193-branch-patcher2.cfg,v  <--  moz193-branch-patcher2.cfg
initial revision: 1.1
done

Comment 17

[[e-mail] (:bhearsum)]

Attachment: don't bump patcher, verify configs

This is a temporary patch we need to run 3.7a3 updates through the automation, because the patcher and verify bumping scripts will ruin our lovely configs.

Comment 18

[[e-mail] (:bhearsum)]

Comment on attachment 432784 [details] [diff] [review]
verify configs with nick's comments addressed

changeset:   535:6e420bf20bec

Comment 19

[[e-mail] (:bhearsum)]

Comment on attachment 432788 [details] [diff] [review]
don't bump patcher, verify configs

changeset:   646:2fcc839719f2

Comment 20

[[e-mail] (:bhearsum)]

Comment on attachment 432788 [details] [diff] [review]
don't bump patcher, verify configs

Backout in changeset:   652:d29b5fd1fdff

Comment 21

[[e-mail] (:bhearsum)]

Shipped.